This repository has been archived by the owner on May 4, 2024. It is now read-only.
deps: remove readable-stream #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
changed the title
readable-stream with built in Node.js stream module
wraithgar
approved these changes
Jan 3, 2024
Merged
wraithgar
added a commit
that referenced
this pull request
Jan 3, 2024
Inspired by #206, we really don't need an entire library to pass a parameter through to another class
Merged
wraithgar
added a commit
that referenced
this pull request
Jan 5, 2024
Inspired by #206, we really don't need an entire library to pass a parameter through to another class
wraithgar
pushed a commit
that referenced
this pull request
Jan 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.2](v4.0.1...v4.0.2) (2024-01-05) ### Dependencies * [`09d821a`](09d821a) [#207](#207) remove delegates (#207) * [`fef6c21`](fef6c21) [#206](#206) remove readable-stream (#206) ### Chores * [`6c3cebf`](6c3cebf) [#205](#205) postinstall for dependabot template-oss PR (@lukekarrys) * [`809215c`](809215c) [#205](#205) bump @npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot]) * [`8858a73`](8858a73) [#202](#202) postinstall for dependabot template-oss PR (@lukekarrys) * [`b2134b9`](b2134b9) [#202](#202) bump @npmcli/template-oss from 4.19.0 to 4.21.1 (@dependabot[bot]) * [`9acf64b`](9acf64b) [#184](#184) postinstall for dependabot template-oss PR (@lukekarrys) * [`d8bacce`](d8bacce) [#184](#184) bump @npmcli/template-oss from 4.18.1 to 4.19.0 (@dependabot[bot]) * [`9e4783f`](9e4783f) [#182](#182) postinstall for dependabot template-oss PR (@lukekarrys) * [`d55ffbf`](d55ffbf) [#182](#182) bump @npmcli/template-oss from 4.18.0 to 4.18.1 (@dependabot[bot]) * [`08dc9f5`](08dc9f5) [#181](#181) postinstall for dependabot template-oss PR (@lukekarrys) * [`8145faf`](8145faf) [#181](#181) bump @npmcli/template-oss from 4.17.0 to 4.18.0 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dependency on
readable-streammodule which is basically just a mirror of the Node.jsstreammodule. As such, there's no reason to use it over the built in module. There's 0 effect of this change - all tests are passing without touching anything.References