moved permissions before <application> tag #2
Conversation
…) is present or absent...showing a toast when it's absent.
| import com.viaforensics.android.providers.ForensicsProvider; | ||
| import com.viaforensics.android.util.PackageManagerHelper; | ||
| import com.viaforensics.android.view.ForensicsProviderListManager; | ||
|
|
||
| public class ForensicsActivity extends ListActivity implements OnClickListener { | ||
|
|
||
| private static final String TAG = "com.viaforensics.android.ForensicsActivity"; | ||
| public static final String TAG = "com.viaforensics.android.ForensicsActivity"; |
There was a problem hiding this comment.
maybe it's better to leave this tags private and stick to the convention?
|
is the external storage functionality already integrated? |
|
we are just detecting the presence (or absence) of external storage at this point. |
|
ok, so it does not make sense to include it in a pull request for the opensource edition in master, if it's dead code (imo). we can make another pull request for the external sdcard in master when the functionality is complete |
|
yeah. makes sense. we will revisit this when the viaProtect agent release is complete. meantime, feel free to cover missed cases in GetRemovableDevice.java i.e feel free to enhance it as u see fit Marco. It's a good idea to make that class as robust and comprehensive as possible. Currently, it works perfectly fine on a Samsung 5 unrooted device. Regards,
|
testing forking and pull request process for aflogical ose repo
moved permissions before tag