New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add comparison operators helpers #5334
feat: add comparison operators helpers #5334
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -10,6 +10,12 @@ export enum HandlebarHelpersEnum { | |||
SORT_BY = 'sortBy', | |||
NUMBERFORMAT = 'numberFormat', | |||
I18N = 'i18n', | |||
GT = 'gt', | |||
GTE = 'gte', | |||
LT = 'lt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is existing handlebar helper EQUALS
(==
) and it might be confused with EQ
(===
).
Let me know if you have better ideas for naming.
@jainpawan21 @scopsy PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work!
What change does this PR introduce?
This PR introduces new helpers for comparison operators:
<
,<=
,>
,>=
,===
,!==
.Why was this change needed?
Closes #5263
Other information (Screenshots)