feat: add hubspot component in shared web #5286
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } | ||
| `; | ||
|
|
||
| export const HubspotForm = <TProperties extends Record<string, string>>(props: HubspotFormProps<TProperties>) => { |
There was a problem hiding this comment.
This component is a copy of the existing HubspotForm one in the billing-web, please move the another one to shared-web and refactor the code appropriately, otherwise we will lose history and will have two duplicates.
There was a problem hiding this comment.
Also, the form fields have different styles and currently are less accessible IMO, please check the two form styles:
There was a problem hiding this comment.
Shall I use this shared-web Hubspot form in ee-billing-web as well?
There was a problem hiding this comment.
hey @jainpawan21 , yes we should use this shared-web HS form in billing-web too. I can make this change, I'll monitor this PR to be merged first and action appropriately
There was a problem hiding this comment.
the form fields have different styles
The styles here had gone through a design review process with Nik, we might have missed something. Are you expecting darker text and borders @LetItRock ?
There was a problem hiding this comment.
Are you expecting darker text and borders @LetItRock ?
exactly, sorry of not being clear enough ;)
There was a problem hiding this comment.
Fixed theme and colors issue.
Earlier I was using theme from useLocalThemePreference hook, now using mantine one
apps/api/src/app/organization/usecases/create-organization/create-organization.command.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Awesome work @jainpawan21 , could you please add some screenshots to the PR description showing the updated styling, then we will be good to go.
|
|
||
| export default function QuestionnairePage() { | ||
| const { isLoading } = useVercelIntegration(); | ||
| const isNovuProd = !IS_DOCKER_HOSTED && ENV === 'production'; |
There was a problem hiding this comment.
Nice one, I think this is a suitable approach to dealing with local development, it will ensure we serve the Questionnaire form that does not require an internet connection in local.
For the no internet case in Prod, the User would not be able to reach the Novu API to complete the Organization creation anyway, so no further action needed on this path.
Added loom video ✅ |
…vuhq/novu into feature/sign-up-question-form-hubspot
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)
https://www.loom.com/share/525074b569b94f459bba6144a1aaab76