Avoid address sanitizer on MSVC #1622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending on nothings#393 Since MSVC now supports address sanitizer, it appears to be throwing the same issues as other platforms This PR adds compiler checks and appropriate declspecs for MSVC
|
You might add UBSAN as well, since it also flags the tricks used in sprintf library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending on #393
Since MSVC now supports address sanitizer, it appears to be throwing the same issues as other platforms
This PR adds compiler checks and appropriate declspecs for MSVC
Note that _declspec for MSVC must appear before the storage specifier, hence the additional set of STBSP__PUBLICDEF's
There's probably a cleaner way to structure that