Make fallthroughs explicit in stb_image.h #1615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-Wimplicit-fallthrough` flag can be used to check for implicit fallthroughs, which are a common source of errors. I've added and used `STBI_FALLTHROUGH` which maps to `__attribute__((fallthrough))`, which the compiler uses to determine whether a fallthrough is explicit or not.
|
This needs to work on all compilers, so the define needs to be an ifdef which tests for suitable compilers, with an else that defines it to nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Wimplicit-fallthroughflag can be used to check for implicit fallthroughs, which are a common source of errors.I've added and used
STBI_FALLTHROUGHwhich maps to__attribute__((fallthrough)), which the compiler uses to determine whether a fallthrough is explicit or not.