Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating testing certificates #1676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefbog
Copy link

@stefbog stefbog commented Apr 27, 2023

The test certificates expired and we need to regenerate them so that notary works in a local environment.

This is similar to previous pull request (#1594) .

Signed-off-by: Stefan Bogoevski <stefan.bogoevski@sap.com>
@stefbog stefbog force-pushed the regenerate-testing-certificates branch from c9c7a6b to c98221f Compare April 27, 2023 14:26
@stefan-zh
Copy link

stefan-zh commented Apr 27, 2023

@justincormack We are experiencing failing CI/CD jobs at our company because of this (some of the notary tests are failing), and would appreciate if someone could look into this pull request. Thanks!

@stefan-zh
Copy link

@justincormack @HuKeping @jonnystoten Is any of you able to take a look at this PR? Notary is unusable without updating the certificates..

Copy link
Contributor

@jonnystoten jonnystoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@stefan-zh
Copy link

Thanks @jonnystoten ! @justincormack I imagine this is ready to go to master?

@stefbog
Copy link
Author

stefbog commented Jul 17, 2023

Hi @justincormack , @jonnystoten , @stefan-zh ,
we have a follow up question about the required checks that need to be run successfully before merging.
In our case the Go version is 1.17 and here -> https://app.circleci.com/pipelines/github/notaryproject/notary/251/workflows/6af16ca5-7914-4ca6-b057-d0b3faecb114/jobs/6592?invite=true#step-105-35
it says that the module requires to be 1.19 and it fails. Probably the follow up check for the codecov/project is stuck to "waiting" and we cannot merge.
Can someone please give us a recommendation on how we can proceed here (maybe you can merge from you side) or maybe we should retrigger the pipeline to see if the expected status to change, but as I understand the lint step will continue to fail because of the version. I hope that you can provide some advice on how we should proceed.
Thank you in advance.

@secOHps
Copy link

secOHps commented Aug 29, 2023

Hi all, Doug Singer here -- DevSecOps Engineer for Modern Technology Solutions, INC.

In the process of doing some R&D for our dept, I was investigating this project. Ran into the x509 expiration issue and found this thread. Looks like this PR may resolve the issue we're having, so I will keep an eye on it. Thank you, all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants