Bugfix: Case-insensitive comparison of the Common Name to the GUN in x509 validation #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-zh
force-pushed
the
bugfix/case-insensitive-comparison-common-name-gun
branch
from
618ff83
to
2c99de2
Compare
…x509 certificate validation Signed-off-by: Stefan Zhelyazkov <stefan.zhelyazkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work I encountered a bug where the Common Name and the GUN differ only in their capitalization:
DEBU[0001] error leaf certificate CN: example.com/repository/LPF doesn't match the given GUN: example.com/repository/lpfIt turns out that capitalization shouldn't matter for CN and SANs in x509 certificates: https://security.stackexchange.com/a/150776
Therefore, I am proposing that Notary compares the two strings in a case-insensitive manner.