Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW: Do not include gomp #37

Closed
lofidevops opened this issue Aug 3, 2015 · 2 comments
Closed

MinGW: Do not include gomp #37

lofidevops opened this issue Aug 3, 2015 · 2 comments

Comments

@lofidevops
Copy link

Steps to reproduce:

Build on a MinGW platform

What should happen:

Build successful.

What happens instead:

Fails due to dependency on GOMP/libgomp.

Notes:

MinGW is unusual in that it is both a GCC platform and a Windows platform. Unlike other GCC platforms, it is not guaranteed that GOMP is installed (afaik no MinGW installation currently includes GOMP).

Thus the CMake logic to include GOMP should be something like:

if (platform == GCC) and (platform != MinGW):
    include gomp

Workaround:

lofidevops@1e13351

Edit CMake files so that gomp is never included. This is obviously not a long-term solution.

@simonlynen
Copy link
Collaborator

We would just need to change the cmake to also check for mingw. Could you
open a pull-request that adds this check to cmake? Since I dont have a
setup to test this.

No further changes to the code should be needed.

Thanks

On Mon, Aug 3, 2015, 16:59 d❤vid seaward notifications@github.com wrote:

Steps to reproduce:

Build on a MinGW platform

What should happen:

Build successful.

What happens instead:

Fails due to dependency on GOMP/libgomp.

Notes:

MinGW is unusual in that it is both a GCC platform and a Windows platform.
Unlike other GCC platforms, it is not guaranteed that GOMP is installed
(afaik no MinGW installation currently includes GOMP).

Thus the CMake logic to include GOMP should be something like:

if (platform == GCC) and (platform != MinGW):
include gomp

Workaround:

kwill@1e13351
lofidevops@1e13351

Edit CMake files so that gomp is never included. This is obviously not a
long-term solution.


Reply to this email directly or view it on GitHub
#37.

@lofidevops
Copy link
Author

See #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants