Add ERC support #119
Open
Add ERC support #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERC is the IRC client which is built-in to Emacs. This should be a decently complete theme, personally I had only changed about 4 faces to get it to a usable state for myself, however before submitting I went above and beyond and set several more. I did not, however, set any of the fg:erc-color-face[0-15] nor bg:erc-color-face[0-15], as I have never even seen those used anywhere (maybe on a terminal? but I am GUI user). There were a few more oddball ones I did not bother with either, but I don't think they are important and I never saw them used anywhere, either.
|
I did also use Nord colors for the custom nick coloring, I could make another PR and put that in contrib(?) or maybe just paste the code up somewhere if anyone is interested. It was basically just something I copped off EmacsWiki and modified a bit. |
svengreb
force-pushed
the
develop
branch
3 times, most recently
from
aa83e0d
to
5335a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC is the IRC client which is built-in to Emacs.
This should be a decently complete theme, personally I had only changed about 4 faces to get it to a usable state for myself, however before submitting I went above and beyond and set several more.
I did not, however, set any of the fg:erc-color-face[0-15] nor bg:erc-color-face[0-15], as I have never even seen those used anywhere (maybe on a terminal? but I am GUI user). There were a few more oddball ones I did not bother with either, but I don't think they are important and I never saw them used anywhere, either.
I took a couple screen shots:
N.B.: I am using some custom ELisp to assign different colors to different nicks, that is not part of this commit.