Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype access_rules diff for roles. #503

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prototype access_rules diff for roles. #503

wants to merge 2 commits into from

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Jul 20, 2023

access_rules for AWS IAM Roles is pure metadata changes. This metadata change is import for third party support. This is an experimental feature to calculate such metadata changes. This is still considered experimental.

2023/07/19 20:00:58 [info     ] A detailed summary of changes has been saved to proposed_changes.txt
IAMbic Summary

Change Detection

* 1 distinct actions.
* 1 templates with changes.
* 1 accounts affected.

Exceptions
* 0 exceptions were recorded.
IAMbic Change Details
Update
└── ../noq-templates-orig/../noq-templates-orig/resources/aws/iam/role/iambic_open_source/iambic_docs_publishing.yaml
    └── NONE
        └── aws:iam:role // iambic_docs_publisher

A Git PR Example

What changed?

  • Describe the change in high level terms.

Rationale

  • Explain the rationale behind this change and the approach.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

access_rules for AWS IAM Roles is pure metadata changes. This metadata
change is import for third party support. This is an experimental feature
to calculate such metadata changes. This is still considered experimental.
@smoy smoy self-assigned this Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: -0.03% ⚠️

Comparison is base (7b8349e) 85.80% compared to head (4d05a10) 85.78%.

❗ Current head 4d05a10 differs from pull request most recent head 43ebdcc. Consider uploading reports for the commit 43ebdcc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   85.80%   85.78%   -0.03%     
==========================================
  Files         103      103              
  Lines       11754    11781      +27     
==========================================
+ Hits        10086    10106      +20     
- Misses       1668     1675       +7     
Flag Coverage Δ
functional_tests 67.72% <17.85%> (-0.28%) ⬇️
functional_tests_config_discovery 47.10% <0.00%> (-0.07%) ⬇️
unit_tests 75.72% <64.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
iambic/request_handler/git_apply.py 78.78% <64.28%> (-10.96%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Upgrade base linux distro to Amazon Linux 2023
* Upgrade Python to 3.10.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant