Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to update credentials manually to an account #1344

Merged
merged 1 commit into from
May 22, 2024

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Apr 15, 2024

Explain the changes

  1. Added a CLI command to manually update account credentials (access key and secret key). Users can provide the access key and secret key as flags, or they will be prompted to enter them if the flags are not specified.
    For example: noobaa account credentials --access-key=<access-key> --secret-key=<secret-key>

Additionally, validation checks have been implemented for both keys to ensure the command succeeds only with valid credentials.

Testing Instructions:

  1. make test-cli-flow
  • Tests added

@achouhan09 achouhan09 requested review from liranmauda, naveenpaul1, a team and nbecker-cibot and removed request for a team April 15, 2024 15:03
@achouhan09 achouhan09 requested review from shirady and removed request for nbecker-cibot April 15, 2024 15:04
pkg/nb/types.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
@shirady
Copy link
Contributor

shirady commented Apr 18, 2024

@achouhan09,
General question - At which stage will the user set the credentials manually to the account?

@achouhan09
Copy link
Member Author

achouhan09 commented Apr 23, 2024

@achouhan09, General question - At which stage will the user set the credentials manually to the account?

@shirady
As per the Epic, user requirement is to access both local and remote enpoints which require different credentials. Also, this feature will help in real object DR solution, allowing application write to s3 endpoint via load balancer and replicate the data in the background.

pkg/nb/types.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
@achouhan09 achouhan09 force-pushed the set_cred branch 2 times, most recently from 8c3f82f to 8f39fa5 Compare May 16, 2024 13:07
@achouhan09 achouhan09 marked this pull request as draft May 16, 2024 13:07
@achouhan09 achouhan09 marked this pull request as ready for review May 17, 2024 07:58
@achouhan09 achouhan09 closed this May 20, 2024
@achouhan09 achouhan09 deleted the set_cred branch May 20, 2024 08:30
@achouhan09 achouhan09 restored the set_cred branch May 20, 2024 08:31
@achouhan09 achouhan09 reopened this May 20, 2024
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@achouhan09 achouhan09 merged commit a88f3cc into noobaa:master May 22, 2024
14 checks passed
@achouhan09 achouhan09 deleted the set_cred branch May 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants