Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Adding NC_DISABLE_ACCESS_CHECK and NC_DISABLE_SCHEMA_CHECK configurations #8043

Merged
merged 1 commit into from
May 21, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 12, 2024

Explain the changes

  1. Adding NC_DISABLE_ACCESS_CHECK and NC_DISABLE_SCHEMA_CHECK in order to have a less strict behavior.
  2. NC_DISABLE_ACCESS_CHECK description -
This flag will disable Read/Write accessibility validations in the following flows - 
1. Bucket creation/update - NooBaa will not validate that the bucket owner has read/write permissions to the bucket's path.
2. Account creation/update - NooBaa will not validate that the account owner has read/write permissions to the account's new_buckets_path.
Warning - setting this configuration to true might result with unexpected behavior.
  1. NC_DISABLE_SCHEMA_CHECK description -
This flag will disable configuration/account/bucket schema checks. Warning: After setting this configuration, NooBaa will skip schema validations and one can create invalid accounts/buckets entities or apply invalid configuration which may cause an unexpected behavior.    

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. sudo jest --testRegex=jest_tests/test_nc_nsfs_config_schema
  2. sudo jest --testRegex=jest_tests/test_nc_nsfs_account_schema
  3. sudo jest --testRegex=jest_tests/test_nc_nsfs_bucket_schema
  4. sudo jest --testRegex=jest_tests/test_nc_nsfs_account_cli
  5. sudo jest --testRegex=jest_tests/test_nc_nsfs_bucket_cli
  • Doc added/updated
  • Tests added

@romayalon romayalon marked this pull request as draft May 12, 2024 14:58
@romayalon romayalon requested a review from guymguym May 13, 2024 07:11
@romayalon romayalon marked this pull request as ready for review May 15, 2024 15:35
@romayalon romayalon force-pushed the romy-add-disable-checks branch 2 times, most recently from 6ad7ead to 9026256 Compare May 19, 2024 13:11
@romayalon romayalon added this to the 5.15.4 milestone May 20, 2024
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit d36156b into noobaa:master May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants