Remove eslint-disable no-undef And Add Jest in Eslint Config
#8042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
jest-eslint-config-avoid-no-undef
branch
from
64982f2
to
64a9a23
Compare
1. Remove eslint-disable no-undef in the Jest test files and add jest in eslint config. 2. Add the function fail in file test_nc_master_keys.test. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
jest-eslint-config-avoid-no-undef
branch
from
64a9a23
to
d1370c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
eslint-disable no-undefin the Jest test files and add jest in eslint config.failin filetest_nc_master_keys.test.Issues: Fixed #xxx / Gap #xxx
eslint-disable no-undef, by adding the jest environment (here).Testing Instructions:
Jest Unit Tests.After removing the
eslint-disable no-undefI saw that:Please run:
sudo npx jest test_nc_master_keys.test.js.