Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to update credentials manually to an account #7972

Merged
merged 1 commit into from May 20, 2024

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Apr 15, 2024

Explain the changes

  1. Added an API update_account_keys to update the account credentials (access key and secret key) manually. It requires email and access_keys as the input parameters.

@achouhan09 achouhan09 requested review from a team and shirady and removed request for a team April 15, 2024 15:01
@shirady
Copy link
Contributor

shirady commented Apr 16, 2024

@achouhan09 what about the complexity of the credentials?
Can I send access_key "123" and secret_key "123"?

@achouhan09
Copy link
Member Author

@achouhan09 what about the complexity of the credentials? Can I send access_key "123" and secret_key "123"?

@shirady Yes needs to be added, I will put the validation for complexity. Thanks!

@liranmauda
Copy link
Contributor

@achouhan09 what about the complexity of the credentials? Can I send access_key "123" and secret_key "123"?

@shirady Yes needs to be added, I will put the validation for complexity. Thanks!

I am not convinced that we need to protect it.
it is an internal API.
We do not protect it on create nor update
@dannyzaken WDYT?

@dannyzaken
Copy link
Contributor

@liranmauda @achouhan09 why do we need update_account_keys?

@liranmauda
Copy link
Contributor

@liranmauda @achouhan09 why do we need update_account_keys?

We need to set credentials manually to an account
This is part of an Epic for 5.17

@achouhan09 achouhan09 requested a review from shirady May 13, 2024 13:47
@achouhan09 achouhan09 force-pushed the set_cred branch 2 times, most recently from 4b0acf6 to f48d357 Compare May 16, 2024 09:51
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@achouhan09 achouhan09 merged commit a5226f9 into noobaa:master May 20, 2024
10 checks passed
@achouhan09 achouhan09 deleted the set_cred branch May 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants