NSFS | NC | Changes in nsfs_config_schema Related to strictify

[shirady]

Explain the changes

1. Add strictify on nsfs_config_schema.
2. Change the structure of the schema nsfs_config_schema:
   • Replace the description with doc.
   • Remove default.
   • In NSFS_WHITELIST which is type array add items under it.
   • Remove the definitions in nsfs_config_schema and set the additionalProperties to nsfs_node_config_schema.
3. Edit the printings in load_nsfs_nc_config.

Issues: Fixed #7874

1. Those changes are originally from after setting strictify on nsfs_config_schema and handling the errors.

GAPS:

1. GAP - I think we should add validations to some of the properties, for example: NSFS_WHITELIST is validated when the user passes the command sudo node src/cmd/manage_nsfs whitelist --ips <list-og-ips> using verify_whitelist_ips:
   

   noobaa-core/src/cmd/manage_nsfs.js

   Lines 993 to 1000 in d1bf8c4

   	function verify_whitelist_ips(ips_to_validate) {
   	for (const ip_to_validate of ips_to_validate) {
   	if (net.isIP(ip_to_validate) === 0) {
   	const detail_msg = `IP address list has an invalid IP address ${ip_to_validate}`;
   	throw_cli_error(ManageCLIError.InvalidWhiteListIPFormat, detail_msg);
   	}
   	}
   	}

2. GAP (suggestion) - We can translate our recommendations in the schema, for example: ports values 1-65535 using a definition that we have:
   

   noobaa-core/src/api/common_api.js

   Lines 1204 to 1208 in d1bf8c4

   	port: {
   	type: 'integer',
   	minimum: 0,
   	maximum: 65535
   	},

   
   In other cases, for example ENDPOINT_FORKS to be minimum 0 and maximum 64 and remove the suggestions from the doc part.

Testing Instructions:

Unit Tests

1. Run the schema unit tests: npx jest test_nc_nsfs_config_schema_validation.test.js

Manual Tests

To see that the config is used when running the nsfs server.

1. Check your hostname, run: hostname in your terminal (this will be the <hostname-output> in the next step).
2. Add a config file: sudo vi /etc/noobaa.conf.d/config.json In this example we added 2 opposite values of ALLOW_HTTP

 {
     "ALLOW_HTTP": false,
     "host_customization": {
         "<hostname-output>": {
             "ALLOW_HTTP": true
         }
     }
 }

3. Start the server: sudo node src/cmd/nsfs --debug 5
4. Notice the printings (my-mac is an example of a hostname):

nsfs: config_dir_path=/etc/noobaa.conf.d
nsfs: config.json= {
  ALLOW_HTTP: false,
  host_customization: { 'my-mac': { ALLOW_HTTP: true } }
}
nsfs: merged config.json= { ALLOW_HTTP: true }

[nsfs/75607]    [L0] core.endpoint.endpoint:: Starting S3 HTTP 6001
[nsfs/75607]    [L0] core.endpoint.endpoint:: Started S3 HTTP successfully

• Doc added/updated
• Tests added

[romayalon]

Awesome!
Please open a single issue for the suggested extra validations :)