Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update s3_rest error message on unsupported op #7534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update s3_rest error message on unsupported op #7534

wants to merge 1 commit into from

Conversation

rhkelson
Copy link

Explain the changes

  1. Changed line 258 to include a smaller, more informative error message when dealing with unsupported s3 operations.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

guymguym
guymguym approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!!

@guymguym
Copy link
Member

guymguym commented Mar 4, 2024

@rhkelson can you please handle the DCO check - you need to sign off your commit with git rebase -s

@guymguym guymguym changed the title Update s3_rest.js Update s3_rest error message on unsupported op Mar 4, 2024
@rhkelson @guymguym
Update s3_rest.js
d15b10e 
Changed line 258 to include a smaller, more informative error message when dealing with unsupported s3 operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhkelson @guymguym