Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | moving util functions to native_fs_utils.js file and some cleanup #7463

Closed
wants to merge 4 commits into from
Closed

NSFS | moving util functions to native_fs_utils.js file and some cleanup #7463

wants to merge 4 commits into from

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. On nb.d NativeFSContext backend is 'GPFS', I suggest change it to be a string
  2. Removed secret logging
  3. Started moving some unbounded util functions to native_fs_utils.js
  4. Converted hard coded 'null' to NULL_VERSION_ID variable
  5. Re-used is_versioning_enables/suspended functions
  6. Added some missing parameteres to NamespaceFS object on test_namespace_fs.js

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon mentioned this pull request Sep 11, 2023
Merged
@romayalon romayalon mentioned this pull request Sep 18, 2023
Merged
2 tasks
@romayalon
cleanup2
3e0d41c 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon
Namespace fs - move non bounded functions to native fs utils
ddeda2e 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon
convert hard coded null string to NULL_VERSION_ID var
9027b67 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon
call _is_versioning function for checking statuses
4cab88c 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
naveenpaul1
naveenpaul1 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Apr 25, 2024
@github-actions GitHub Actions
Copy link

This PR is stale and had no activity for too long - it will now be closed.

@github-actions github-actions bot closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

@guymguym guymguym Awaiting requested review from guymguym

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees
No one assigned
Labels
size/XL Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @naveenpaul1