Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debugging easier by printing relevant errors #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShellCode33
Copy link
Contributor

Hi ! Thanks for this amazing tool ! I came across an error and to be honest, debugging arm_now was an absolute nightmare... I spent almost 2 hours digging into the code just to realize the FS wasn't big enough...
This PR improves errors printing and should help future users to understand what's wrong with their setup

@SakiiR
Copy link
Collaborator

SakiiR commented Sep 2, 2019

Hey @ShellCode33 there is issue with ur PR (Conflicts)

@ShellCode33
Copy link
Contributor Author

ShellCode33 commented Sep 2, 2019

It was indeed in conflict, I included a commit in the PR which shouldn't have been there. Should be ok now.

@SakiiR
Copy link
Collaborator

SakiiR commented Sep 2, 2019

Hey buddy,

It seems to not work on MacOs :) Can u check ?

Screenshot 2019-09-02 at 11 40 20

@SakiiR
Copy link
Collaborator

SakiiR commented Sep 2, 2019

@ShellCode33
Copy link
Contributor Author

This is not related to this PR but more to this one #36, you are probably using a pretty old version of qemu... Can't you upgrade it ? Otherwise the thing to do is to check qemu's version beforehand and use the appropriate parameter, which is kind of ugly :/

@SakiiR
Copy link
Collaborator

SakiiR commented Sep 2, 2019

Sorry @ShellCode33 I don't understand, what is the new syntax ? --redir or -nic user,hostfwd=tcp::8080-:80

@SakiiR
Copy link
Collaborator

SakiiR commented Sep 2, 2019

Here is my version of qemu-system-arm:

- tmux % qemu-system-arm --version                                                                                                                                                                                                                         
QEMU emulator version 4.1.0
Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers

@ShellCode33
Copy link
Contributor Author

ShellCode33 commented Sep 2, 2019

Oh ok I see ! You are still using the old qemu's -redir, do not clone my repo as is, it only contains this PR, not the other PR I've made about the ports redirection fix. But again, this PR is not about port redirection, it's just an errors printing improvement

Just to be clear :

  • -redir is the old qemu's way to redirect a port, it has been removed in qemu 3.1.0
  • -nic is the new way to redirect a port
  • --redir is the command line parameter to give to arm_now to redirect a port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants