Skip to content

Commit

Permalink
Update Tap Dance Example 4 (qmk#18138)
Browse files Browse the repository at this point in the history
break statements are missing from the switch for both registering and unregistering key codes. Neither have a default: case either. The code as exists in the repository right now does not compile. It does with this changes.
  • Loading branch information
jessearmstrong authored and nolanseaton committed Jan 23, 2023
1 parent dd6c35e commit 47856c1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions docs/feature_tap_dance.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ void x_finished(qk_tap_dance_state_t *state, void *user_data) {
// Last case is for fast typing. Assuming your key is `f`:
// For example, when typing the word `buffer`, and you want to make sure that you send `ff` and not `Esc`.
// In order to type `ff` when typing fast, the next character will have to be hit within the `TAPPING_TERM`, which by default is 200ms.
case TD_DOUBLE_SINGLE_TAP: tap_code(KC_X); register_code(KC_X);
case TD_DOUBLE_SINGLE_TAP: tap_code(KC_X); register_code(KC_X); break;
default: break;
}
}

Expand All @@ -341,8 +342,9 @@ void x_reset(qk_tap_dance_state_t *state, void *user_data) {
case TD_SINGLE_TAP: unregister_code(KC_X); break;
case TD_SINGLE_HOLD: unregister_code(KC_LCTL); break;
case TD_DOUBLE_TAP: unregister_code(KC_ESC); break;
case TD_DOUBLE_HOLD: unregister_code(KC_LALT);
case TD_DOUBLE_SINGLE_TAP: unregister_code(KC_X);
case TD_DOUBLE_HOLD: unregister_code(KC_LALT); break;
case TD_DOUBLE_SINGLE_TAP: unregister_code(KC_X); break;
default: break;
}
xtap_state.state = TD_NONE;
}
Expand Down

0 comments on commit 47856c1

Please sign in to comment.