Merge pull request #141 from lukmarcus/great-companies-optional-url

Great Companies optional url
noisy · Apr 21, 2024 · da00c7d · da00c7d
2 parents 83472ce + 661d703
commit da00c7d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/components/Companies.vue b/src/components/Companies.vue
@@ -10,13 +10,24 @@
           :key="company.name"
           class="px-3 col-6 col-md-4 col-lg-2 px-md-5 px-lg-4"
         >
-          <a class="logo-link" :href="company.url" target="_blank">
+          <a
+            v-if="company.url"
+            class="logo-link"
+            :href="company.url"
+            target="_blank"
+          >
             <img
               class="grayscale img-fluid svg-ie-fix"
               :src="getAsset(`@/images/${company.logo}`)"
               :title="company.name"
             />
           </a>
+          <img
+            v-else
+            class="grayscale img-fluid svg-ie-fix"
+            :src="getAsset(`@/images/${company.logo}`)"
+            :title="company.name"
+          />
         </div>
       </div>
     </div>

diff --git a/src/types/IProject.ts b/src/types/IProject.ts
@@ -87,7 +87,7 @@ export interface IProject {
 }
 export interface ICompany {
   name: string;
-  url: string;
+  url?: string;
   logo: string;
 }
 export interface ISkillGroup {