fix: nodeshift should check that there is a name field in the package…

….json

examples/sample-project-no-name/package.json

@@ -0,0 +1,11 @@
+{
+  "version": "1.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC"
+}

lib/config/nodeshift-config.js

@@ -150,6 +150,11 @@ async function setup (options = {}) {
 
   logger.info(`using namespace ${config.namespace.name} at ${kubeConfig.getCurrentCluster().server}`);
 
+  // Check that the package.json has a name field first
+  if (!projectPackage.name) {
+    throw new Error('could not find required field "name" in package.json');
+  }
+
   if (!projectPackage.name.match(/^(@[a-z0-9-~][a-z0-9-._~]*\/)?[a-z0-9-~][a-z0-9-._~]*$/)) {
     throw new Error('"name" in package.json can only consist lower-case letters, numbers, and dashes. It must start with a letter and can\'t end with a -.');
   }

test/config-tests/nodeshift-config-test.js

@@ -280,6 +280,51 @@ test('nodeshift-config no project Version', (t) => {
   });
 });
 
+test('nodeshift-config no project name', (t) => {
+  const nodeshiftConfig = proxyquire('../../lib/config/nodeshift-config', {
+    './login-config': {
+      doNodeshiftLogin: () => {
+        t.fail('This should not be called');
+      },
+      doNodeshiftLogout: () => {
+        t.fail('This should not be called');
+        return Promise.resolve();
+      },
+      checkForNodeshiftLogin: () => {
+        t.pass();
+        return Promise.resolve();
+      }
+    },
+    'openshift-rest-client': {
+      OpenshiftClient: () => {
+        return Promise.resolve({
+          kubeconfig: {
+            getCurrentContext: () => {
+              return 'nodey/ip/other';
+            },
+            getCurrentCluster: () => {
+              return { server: 'http://mock-cluster' };
+            },
+            getContexts: () => {
+              return [{ name: 'nodey/ip/other', namespace: 'test-namespace' }];
+            }
+          }
+        });
+      }
+    }
+  });
+
+  const options = {
+    projectLocation: './examples/sample-project-no-name'
+  };
+
+  nodeshiftConfig(options).catch((error) => {
+    console.log(error);
+    t.equal(error.message.includes('could not find required field "name" in package.json'), true);
+    t.end();
+  });
+});
+
 test('nodeshift-config no package.json', (t) => {
   const nodeshiftConfig = proxyquire('../../lib/config/nodeshift-config', {
     './login-config': {