Merge commit 'rbenv-tags/v1.2.0' into pull-rbenv

* commit 'rbenv-tags/v1.2.0':
  rbenv 1.2.0
  Clarify bash config for Ubuntu Desktop vs. other platforms
  💅 Clean up version sorting and add test
  Sort versions semantically in rbenv versions
  Have shims survive symlinked rbenv updates a la Homebrew
  GitHub now auto-generates a Table of Contents
  Speed up rehash
  Have `rbenv init` print instructions that hardcode the detected shell
  Supply `head -n` flag explicitly
  Update rbenv-doctor link master -> main
  Updated rbenv-doctor url to reflect renaming master branch to main
  Fix link to rbenv-doctor
  test(init): remove misleading arg in detect from parent shell case
  feat(init): strip -<suffix> when autodetecting shell
  [DOCS] Typo and formatting fix.
  Use a better PS4 as recommeneded by Bash Hackers Wiki
  Update README.md
  README: reflect changes in rbenv/ruby-build#1402
  Rename CONDUCT.md to CODE_OF_CONDUCT.md
  bash completion: avoid unintentional globbing
  Make work in set -u (nounset) mode
  Spelling fix
  Remove agignore
  Fix fish instructions test
  Remove another `fish` psub usage
  Fix fish shell initialization
  Use `actions/checkout` v2
  Run CI for pull requests from forks
  Re-add zsh completion script and remove fish completion script
  Remove fish completion script
  Fix (revert) test/version-origin.bats
  libexec/rbenv-version{,-origin}: move "missing rbenv-version-file detection" logic as per @mislav
  Fix tests for #1203
  libexec/rbenv-version{,-origin}: fix earlier commit to allow for RBENV_VERSION env var
  libexec/rbenv-version: get rid of misleading "set by $(rbenv-version-origin)" message when system ruby is in use
  test/run: handle optional paths/args for bats
  Documentation unclear

Author: jasonkarns

.agignore

@@ -147,20 +147,38 @@ Version names to nodenv are simply the names of the directories or symlinks in
 
 ## Installation
 
-### Homebrew on macOS
+### Using Package Managers
 
+1. Install nodenv.
+- **macOS**
 If you're on macOS, we recommend installing nodenv with
 [Homebrew](https://brew.sh).
 
-1. Install nodenv.
-
     ~~~ sh
     $ brew install nodenv
     ~~~
 
    Note that this also installs `node-build`, so you'll be ready to
    install other Node versions out of the box.
 
+  - **Upgrading with Homebrew**
+
+    To upgrade to the latest nodenv and update node-build with newly released
+    Node versions, upgrade the Homebrew packages:
+
+    ~~~ sh
+    $ brew upgrade nodenv node-build
+    ~~~
+- **Debian, Ubuntu and their derivatives**
+    ~~~ sh
+    $ sudo apt install nodenv
+    ~~~
+- **Arch Linux and it's derivatives**
+
+  Archlinux has an [AUR Package](https://aur.archlinux.org/packages/nodenv/) for
+  nodenv and you can install it from the AUR using the instructions from this
+  [wiki page](https://wiki.archlinux.org/index.php/Arch_User_Repository#Installing_and_upgrading_packages).
+
 2. Set up nodenv in your shell.
 
     ~~~ sh
@@ -178,7 +196,7 @@ If you're on macOS, we recommend installing nodenv with
 4. Verify that nodenv is properly set up using this [nodenv-doctor][] script:
 
     ~~~ sh
-    $ curl -fsSL https://github.com/nodenv/nodenv-installer/raw/master/bin/nodenv-doctor | bash
+    $ curl -fsSL https://github.com/nodenv/nodenv-installer/raw/main/bin/nodenv-doctor | bash
     Checking for `nodenv' in PATH: /usr/local/bin/nodenv
     Checking for nodenv shims in PATH: OK
     Checking `nodenv install' support: /usr/local/bin/nodenv-install (node-build 3.0.22-4-g49c4cb9)
@@ -193,16 +211,6 @@ If you're on macOS, we recommend installing nodenv with
    `nodenv install`.
 
 
-#### Upgrading with Homebrew
-
-To upgrade to the latest nodenv and update node-build with newly released
-Node versions, upgrade the Homebrew packages:
-
-~~~ sh
-$ brew upgrade nodenv node-build
-~~~
-
-
 ### Basic GitHub Checkout
 
 For a more automated install, you can use [nodenv-installer][].
@@ -229,13 +237,15 @@ a systemwide install.
    command-line utility.
 
    * For **bash**:
+
+     Ubuntu Desktop users should configure `~/.bashrc`:
      ~~~ bash
-     $ echo 'export PATH="$HOME/.nodenv/bin:$PATH"' >> ~/.bash_profile
+     $ echo 'export PATH="$HOME/.nodenv/bin:$PATH"' >> ~/.bashrc
      ~~~
 
-   * For **Ubuntu Desktop** and **Windows Subsystem for Linux (WSL)**:
+     On other platforms, bash is usually configured via `~/.bash_profile`:
      ~~~ bash
-     $ echo 'export PATH="$HOME/.nodenv/bin:$PATH"' >> ~/.bashrc
+     $ echo 'export PATH="$HOME/.nodenv/bin:$PATH"' >> ~/.bash_profile
      ~~~
 
    * For **Zsh**:
@@ -262,7 +272,7 @@ a systemwide install.
 5. Verify that nodenv is properly set up using this [nodenv-doctor][] script:
 
     ~~~ sh
-    $ curl -fsSL https://github.com/nodenv/nodenv-installer/raw/master/bin/nodenv-doctor | bash
+    $ curl -fsSL https://github.com/nodenv/nodenv-installer/raw/main/bin/nodenv-doctor | bash
     Checking for `nodenv' in PATH: /usr/local/bin/nodenv
     Checking for nodenv shims in PATH: OK
     Checking `nodenv install' support: /usr/local/bin/nodenv-install (node-build 3.0.22-4-g49c4cb9)
@@ -349,13 +359,18 @@ provided by the [node-build][] project. If you installed it as part of GitHub
 checkout process outlined above you should be able to:
 
 ~~~ sh
-# list all available versions:
+# list latest stable versions:
 $ nodenv install -l
 
+# list all local versions:
+$ nodenv install -L
+
 # install a Node version:
-$ nodenv install 0.10.26
+$ nodenv install 16.13.2
 ~~~
 
+Set a Node version to finish installation and start using commands `nodenv global 18.14.1` or `rbenv local 18.14.1`
+
 Alternatively to the `install` command, you can download and compile
 Node manually as a subdirectory of `~/.nodenv/versions/`. An entry in
 that directory can also be a symlink to a Node version installed
@@ -407,9 +422,17 @@ uninstall from the system.
         rm -rf `nodenv root`
 
    If you've installed nodenv using a package manager, as a final step
-   perform the nodenv package removal. For instance, for Homebrew:
-
-        brew uninstall nodenv
+   perform the nodenv package removal.
+   - Homebrew:
+
+        `brew uninstall nodenv`
+   - Debian, Ubuntu and their derivatives:
+        
+        `sudo apt purge nodenv`
+  
+   - Archlinux and it's derivatives:
+  
+          `sudo pacman -R nodenv`
 
 ## Command Reference
 
@@ -548,7 +571,7 @@ McKenzie](https://github.com/oinutter) and modified for node.
 
   [hooks]: https://github.com/rbenv/rbenv/wiki/Authoring-plugins#rbenv-hooks
   [node-build]: https://github.com/nodenv/node-build#readme
-  [nodenv-doctor]: https://github.com/nodenv/nodenv-installer/blob/master/bin/nodenv-doctor
+  [nodenv-doctor]: https://github.com/nodenv/nodenv-installer/blob/main/bin/nodenv-doctor
   [nodenv-installer]: https://github.com/nodenv/nodenv-installer#nodenv-installer
   [nodenv-update]: https://github.com/charlesbjohnson/nodenv-update
   [package-rehash-plugin]: https://github.com/nodenv/nodenv-package-rehash

CONDUCT.md renamed to CODE_OF_CONDUCT.md

@@ -6,8 +6,8 @@ _nodenv() {
     COMPREPLY=( $(compgen -W "$(nodenv commands)" -- "$word") )
   else
     local words=("${COMP_WORDS[@]}")
-    unset words[0]
-    unset words[$COMP_CWORD]
+    unset "words[0]"
+    unset "words[$COMP_CWORD]"
     local completions=$(nodenv completions "${words[@]}")
     COMPREPLY=( $(compgen -W "$completions" -- "$word") )
   fi

README.md

@@ -7,7 +7,8 @@ if [ "$1" = "--debug" ]; then
 fi
 
 if [ -n "$NODENV_DEBUG" ]; then
-  export PS4='+ [${BASH_SOURCE##*/}:${LINENO}] '
+  # https://wiki-dev.bash-hackers.org/scripting/debuggingtips#making_xtrace_more_useful
+  export PS4='+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}(): }'
   set -x
 fi
 
@@ -26,7 +27,9 @@ if enable -f "${BASH_SOURCE%/*}"/../libexec/nodenv-realpath.dylib realpath 2>/de
     echo "${path%/*}"
   }
 else
-  READLINK=$(type -p greadlink readlink 2>/dev/null | head -1)
+  [ -z "$NODENV_NATIVE_EXT" ] || abort "failed to load \`realpath' builtin"
+
+  READLINK=$(type -p greadlink readlink 2>/dev/null | head -n1)
   [ -n "$READLINK" ] || abort "cannot find readlink - are you missing GNU coreutils?"
 
   resolve_link() {
@@ -65,6 +68,7 @@ else
 fi
 export NODENV_DIR
 
+[ -n "$NODENV_ORIG_PATH" ] || export NODENV_ORIG_PATH="$PATH"
 
 shopt -s nullglob
 

completions/nodenv.bash

@@ -12,15 +12,14 @@
 set -e
 [ -n "$NODENV_DEBUG" ] && set -x
 
-cd "${BASH_SOURCE%/*}" 2>/dev/null
-
 version=1.4.1
+git_revision=""
 
 semver_compliant() {
   sed -E 's/-([[:digit:]]+)-g([[:alnum:]]+)/+\1.\2/'
 }
 
-if git remote -v 2>/dev/null | grep -q nodenv; then
+if cd "${BASH_SOURCE%/*}" 2>/dev/null && git remote -v 2>/dev/null | grep -q nodenv; then
   git_revision="$(git describe --tags HEAD 2>/dev/null | semver_compliant || true)"
   git_revision="${git_revision#v}"
 fi

completions/nodenv.fish

@@ -43,7 +43,7 @@ extract_initial_comment_block() {
 
 collect_documentation() {
   local awk
-  awk="$(type -p gawk awk 2>/dev/null | head -1)"
+  awk="$(type -p gawk awk 2>/dev/null | head -n1)"
   if [ -z "$awk" ]; then
     echo "nodenv: cannot find awk" >&2
     return 1

libexec/nodenv

@@ -22,30 +22,34 @@ if [ -z "$NODENV_COMMAND" ]; then
 fi
 
 if ! enable -f "${BASH_SOURCE%/*}"/nodenv-realpath.dylib realpath 2>/dev/null; then
-  READLINK=$(type -p greadlink readlink 2>/dev/null | head -1)
-  if [ -z "$READLINK" ]; then
-    echo "nodenv: cannot find readlink - are you missing GNU coreutils?" >&2
+  if [ -n "$NODENV_NATIVE_EXT" ]; then
+    echo "nodenv: failed to load \`realpath' builtin" >&2
     exit 1
   fi
+READLINK=$(type -p greadlink readlink 2>/dev/null | head -n1)
+if [ -z "$READLINK" ]; then
+  echo "nodenv: cannot find readlink - are you missing GNU coreutils?" >&2
+  exit 1
+fi
 
-  resolve_link() {
-    $READLINK "$1"
-  }
+resolve_link() {
+  $READLINK "$1"
+}
 
-  realpath() {
-    local cwd="$PWD"
-    local path="$1"
-    local name
+realpath() {
+  local cwd="$PWD"
+  local path="$1"
+  local name
 
-    while [ -n "$path" ]; do
-      name="${path##*/}"
-      [ "$name" = "$path" ] || cd "${path%/*}"
-      path="$(resolve_link "$name" || true)"
-    done
+  while [ -n "$path" ]; do
+    name="${path##*/}"
+    [ "$name" = "$path" ] || cd "${path%/*}"
+    path="$(resolve_link "$name" || true)"
+  done
 
-    echo "${PWD}/$name"
-    cd "$cwd"
-  }
+  echo "${PWD}/$name"
+  cd "$cwd"
+}
 fi
 
 IFS=: hook_paths=($NODENV_HOOK_PATH)

libexec/nodenv---version

@@ -38,6 +38,7 @@ if [ -z "$shell" ]; then
   shell="${shell##-}"
   shell="${shell:-$SHELL}"
   shell="${shell##*/}"
+  shell="${shell%%-*}"
 fi
 
 root="${0%/*}/.."
@@ -70,10 +71,10 @@ if [ -z "$print" ]; then
     echo
     case "$shell" in
     fish )
-      echo 'status --is-interactive; and source (nodenv init -|psub)'
+      echo 'status --is-interactive; and nodenv init - fish | source'
       ;;
     * )
-      echo 'eval "$(nodenv init -)"'
+      printf 'eval "$(nodenv init - %s)"\n' "$shell"
       ;;
     esac
     echo
@@ -92,14 +93,14 @@ fish )
 * )
   echo 'export PATH="'${NODENV_ROOT}'/shims:${PATH}"'
   echo "export NODENV_SHELL=$shell"
+
+  completion="${root}/completions/nodenv.${shell}"
+  if [ -r "$completion" ]; then
+    echo "source '$completion'"
+  fi
 ;;
 esac
 
-completion="${root}/completions/nodenv.${shell}"
-if [ -r "$completion" ]; then
-  echo "source '$completion'"
-fi
-
 if [ -z "$no_rehash" ]; then
   echo 'command nodenv rehash 2>/dev/null'
 fi
@@ -114,7 +115,7 @@ function nodenv
 
   switch "\$command"
   case ${commands[*]}
-    source (nodenv "sh-\$command" \$argv|psub)
+    nodenv "sh-\$command" \$argv|source
   case '*'
     command nodenv "\$command" \$argv
   end