New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: enable H2 by default #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm strongly against this. I think HTTP2 for most cases is worse both in terms of performance and stability. I'm not a big fan of the quality and lack of maintenance of the http2 module in node core. I would like to even further decouple the http2 stuff from undici core. I would be happy to reconsider this position if and when James's http/3 and quic stuff lands.
I would suggest we enable it by default for fetch and only fetch. It's slow anyway :). |
I believe that most of the inquiries come from |
Hmm, taking another look that won't be that easy; as if we try to scope an Agent just for Unless there's another way I might be missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm -1 with this implementation.
I think a better approach would be to enable it only if the server does not advertise HTTP/1.1 in the TLS exchange. In other terms, if a server is only exposed via HTTP/2, we can support it.
I think we are not ready for turning this on for all requests, there are bugs: #2801. |
SGTM, let's take this back and circle once we feel we are more prepared to it; I'll revisit the bug and seek for support and possible add a fix there 👍 |
This relates to...
Closes #2750
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status