Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FileReader #2728

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

remove FileReader #2728

wants to merge 3 commits into from

Conversation

KhafraDev
Copy link
Member

No description provided.

@KhafraDev KhafraDev added the semver-major Features or fixes that will be included in the next semver major release label Feb 9, 2024
@KhafraDev
Copy link
Member Author

When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore!

@mcollina
Copy link
Member

Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year.

@KhafraDev
Copy link
Member Author

Of course not 😅. I was just talking about way in the future. We still have our own File.

@ronag
Copy link
Member

ronag commented Feb 25, 2024

Rebase to next branch?

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@8a940ec). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2728   +/-   ##
=======================================
  Coverage        ?   88.44%           
=======================================
  Files           ?       81           
  Lines           ?     7384           
  Branches        ?        0           
=======================================
  Hits            ?     6531           
  Misses          ?      853           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev
Copy link
Member Author

can we land this? 👀

@KhafraDev
Copy link
Member Author

I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. web-platform-tests/wpt#44893

Uzlopak
Uzlopak approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhafraDev KhafraDev mentioned this pull request Mar 29, 2024
Merged
6 tasks
@Uzlopak
Copy link
Contributor

Uzlopak commented Apr 8, 2024

I guess this can land in next? What is blocking this?

@KhafraDev
Copy link
Member Author

Now that we've removed our File impl. we can stop running the fileapi WPTs altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees
No one assigned
Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KhafraDev @mcollina @ronag @codecov-commenter @Uzlopak @metcoder95