Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update previous-releases.mdx #6676

Merged
merged 2 commits into from Apr 30, 2024
Merged

Update previous-releases.mdx #6676

merged 2 commits into from Apr 30, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 26, 2024 •
edited

Description

per discussion

We can update the title of the "Previous Releases" to be "Node.js Releases"

Validation

verify titles are changed

Related Issues

  • none yet

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 26, 2024 4:53pm

@srl295
feat(content): Update previous-releases.mdx to rename to Node.js rele…
f82530d 
…ases

Signed-off-by: Steven R. Loomis <srl295@gmail.com>
@srl295
Copy link
Member Author

srl295 commented Apr 26, 2024

image

@srl295 srl295 self-assigned this Apr 26, 2024
@srl295 srl295 marked this pull request as ready for review April 26, 2024 16:52
@srl295 srl295 requested a review from a team as a code owner April 26, 2024 16:52
@theoludwig
Copy link
Contributor

Related issue #6669

theoludwig
theoludwig reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

Except, if we rename it to "Node.js Releases", we should probably also rename the page? From /about/previous-releases to /about/releases (or similar).

@ovflowd
Copy link
Member

ovflowd commented Apr 26, 2024

Mostly LGTM.

Except, if we rename it to "Node.js Releases", we should probably also rename the page? From /about/previous-releases to /about/releases (or similar).

If we rename the link we break a lot of pages. Im fine renaming it although we need a redirect ;)

@srl295
Copy link
Member Author

srl295 commented Apr 26, 2024

Mostly LGTM.

Except, if we rename it to "Node.js Releases", we should probably also rename the page? From /about/previous-releases to /about/releases (or similar).

If we rename the link we break a lot of pages. Im fine renaming it although we need a redirect ;)

I'm not sure how to redirect best. Could one of you update the pr? Or have that as a follow on? This already improved things.

@AugustinMauroy
Copy link
Contributor

IMHO package-manager, prebuilt-binaries and source-code can receive mention of "previous releases"

@srl295 srl295 linked an issue Apr 26, 2024 that may be closed by this pull request
Release schedule too difficult to find #6669
Closed
@srl295
Copy link
Member Author

srl295 commented Apr 26, 2024

IMHO package-manager, prebuilt-binaries and source-code can receive mention of "previous releases"

sounds like it should become a component?

@AugustinMauroy
Copy link
Contributor

sounds like it should become a component?

I didn't get what you want to do.

bmuenzenmeyer
bmuenzenmeyer previously requested changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this explicitly until a redirect is in place - i can guarantee it will break stuff without

@srl295
Copy link
Member Author

srl295 commented Apr 29, 2024

blocking this explicitly until a redirect is in place - i can guarantee it will break stuff without

How does this break? It doesn't rename pages.

@theoludwig
Copy link
Contributor

The renaming can be done on a follow up PR.

ovflowd
ovflowd approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd dismissed bmuenzenmeyer’s stale review April 29, 2024 20:58

The renaming of the file did not happen yet

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
 90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 5.761s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@AugustinMauroy
Copy link
Contributor

if you can change heading level it's can be cool

Capture d’écran 2024-04-30 à 11 36 36

@ovflowd
Copy link
Member

ovflowd commented Apr 30, 2024

if you can change heading level it's can be cool

Capture d’écran 2024-04-30 à 11 36 36

Not related to this PR let's do it as a follow-up

@ovflowd ovflowd added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 69ef8ac Apr 30, 2024
15 checks passed
@ovflowd ovflowd deleted the srl295/previous-releases branch April 30, 2024 18:03
@theoludwig theoludwig mentioned this pull request Apr 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoludwig theoludwig theoludwig left review comments

@ovflowd ovflowd ovflowd approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments

@araujogui araujogui Awaiting requested review from araujogui

@canerakdas canerakdas Awaiting requested review from canerakdas

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release schedule too difficult to find
5 participants
@srl295 @theoludwig @ovflowd @AugustinMauroy @bmuenzenmeyer