New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commitizen to make it easier to follow the Commit Message Guidelines #6659
base: main
Are you sure you want to change the base?
Conversation
This change makes it easier to follow the conventional commits standard by automatically using the commitizen CLI whenever you execute git commit (no flags).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Commitlint config should not be too strict.
I'm honestly debating if I should even keep commitlint in this change. I've changed the config so that it's not terribly strict about the rules. It will allow More strictness just leads to a terrible developer experience because there is no Also, you get 80% of the result anyway if you just use |
I feel that if we are so permissive for commit messages, we lose the reasoning behind CommitLint, no? I do believe adding Semantic Versioning would be great tho!! |
Yeah you're right, I'll update the PR so it's just commitizen in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for you first contribution!
Signed-off-by: Rikard Hallberg <webbman3@gmail.com>
LGTM, @rikhall1515 thanks for contribution. |
Signed-off-by: Rikard Hallberg <r15.hallberg@gmail.com>
Description
This change makes it easier to follow the conventional commits standard by
automatically using the commitizen CLI whenever you execute
git commit
(no -m flag).Validation
I ran
git commit
, used the CLI, and commitizen worked as it should.Related Issues
Check List
npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.