Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move update-v8-5.4.md to announcements folder #6643

Closed

Conversation

reeveng
Copy link

@reeveng reeveng commented Apr 10, 2024

Description

This approach assumes the category was right and it was placed in the wrong folder. The other approach that could fix the issue is switching out the category in the frontmatter, but think this is the right approach.

Validation

Assumed and validated that the path is depended on the location within the folder structure (blog pages in the blog/ folder at least).

Related Issues

Fixes #6641

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@reeveng reeveng requested review from a team as code owners April 10, 2024 23:51
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2024 11:53pm

@reeveng
Copy link
Author

reeveng commented Apr 11, 2024

To fix this in the future, I could also add a "test" that fails the husky precommit, would basically check whether the directory corresponds to the category in the frontmatter.

@reeveng reeveng changed the title fix: switch section from community to announcements fix: switch folder of update-v8-5.4.md from community to announcements Apr 11, 2024
@reeveng reeveng changed the title fix: switch folder of update-v8-5.4.md from community to announcements fix: Reorganize update-v8-5.4.md to Announcements Folder Apr 11, 2024
@reeveng reeveng changed the title fix: Reorganize update-v8-5.4.md to Announcements Folder fix: Reorganize update-v8-5.4.md to announcements folder Apr 11, 2024
@reeveng reeveng changed the title fix: Reorganize update-v8-5.4.md to announcements folder fix: move update-v8-5.4.md to announcements folder Apr 11, 2024
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is not the file name. And it MUST not be changed. This should come from the withSidebarCrossLinks component.

@reeveng
Copy link
Author

reeveng commented Apr 11, 2024

The problem is not the file name. And it MUST not be changed. This should come from the withSidebarCrossLinks component.

Never changed the file name, just the files location. Besides, 2 people working on the same thing doesn't make sense. So since the other PR is more active, the other guy can take it over, not here to waste either of ours time.

@reeveng reeveng closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Broken Link]: Node.js v7 has updated V8 to 5.4
2 participants