Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix watch mode race condition #52954

Merged
merged 1 commit into from May 14, 2024
Merged

test_runner: fix watch mode race condition #52954

merged 1 commit into from May 14, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 12, 2024

Fixes #52936

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner labels May 12, 2024
@MoLow MoLow force-pushed the fix-test-runner-watch-mode branch from b03a4ae to 6d33ed0 Compare May 12, 2024 09:05
@MoLow MoLow requested review from aduh95 and benjamingr May 12, 2024 09:05
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59170/

@MoLow MoLow requested a review from aduh95 May 13, 2024 06:42
@MoLow MoLow force-pushed the fix-test-runner-watch-mode branch from 6d33ed0 to 65586fd Compare May 13, 2024 06:43
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59200/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59201/

@MoLow MoLow requested a review from benjamingr May 13, 2024 10:23
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit c165751 into nodejs:main May 14, 2024
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c165751

@MoLow MoLow deleted the fix-test-runner-watch-mode branch May 14, 2024 20:17
targos pushed a commit that referenced this pull request May 15, 2024
@MoLow @targos
test_runner: fix watch mode race condition
a814e72 
PR-URL: #52954
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@benjamingr benjamingr benjamingr approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch mode duplicates and fails on second run
7 participants
@MoLow @nodejs-github-bot @benjamingr @anonrig @aduh95 @marco-ippolito @atlowChemi