Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update googletest to fa6de7f #52949

Merged
merged 1 commit into from May 14, 2024
Merged

deps: update googletest to fa6de7f #52949

merged 1 commit into from May 14, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of googletest to fa6de7f.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. test Issues and PRs related to the tests. labels May 12, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 12, 2024
@aduh95 aduh95 force-pushed the actions/tools-update-googletest branch from 594ec9c to 5454023 Compare May 12, 2024 07:47
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59169/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 12, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59190/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59196/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59197/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8125a7e into main May 14, 2024
56 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-googletest branch May 14, 2024 00:46
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 8125a7e

targos pushed a commit that referenced this pull request May 15, 2024
@nodejs-github-bot @targos
deps: update googletest to fa6de7f
ab7219f 
PR-URL: #52949
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 15, 2024
Merged
targos pushed a commit that referenced this pull request May 21, 2024
@nodejs-github-bot @targos
deps: update googletest to fa6de7f
f5cd125 
PR-URL: #52949
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nodejs-github-bot @lpinca @RafaelGSS @marco-ippolito @aduh95