Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: drop base64 dep in GN build #52856

Merged
merged 1 commit into from
May 8, 2024
Merged

build: drop base64 dep in GN build #52856

merged 1 commit into from
May 8, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented May 6, 2024

It is no longer a dependency after #52714.

@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Fast-track has been requested by @targos. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58986/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58999/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2024
@zcbenz zcbenz added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 95c16b2 into nodejs:main May 8, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 95c16b2

@zcbenz zcbenz deleted the base64-dep branch May 8, 2024 01:43
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@zcbenz @Ch3nYuY
build: drop base64 dep in GN build
6a0c125 
PR-URL: nodejs#52856
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request May 8, 2024
@zcbenz @targos
build: drop base64 dep in GN build
aea6ca2 
PR-URL: #52856
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zcbenz @nodejs-github-bot @lpinca @anonrig @targos @VoltrexKeyva @RedYetiDev