Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix --v8-lite-mode build #52725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Apr 27, 2024

Fixes: #52710

This patch modifies the build config to compile the error-causing files under the v8_enable_webassembly condition.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 27, 2024
@davidfiala
Copy link

Thank you!

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@daeyeon
Copy link
Member Author

daeyeon commented Apr 29, 2024

https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5945/

The CI test error seems to require a fix for #51308.

12:20:46     1480c755c560 8 JS:~functionTwo /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:13:21
12:20:46     1480c755c600 3c JS:~functionOne /home/iojs/build/workspace/node-test-commit-v8-linux/test/fixtures/linux-perf-logger.js:7:21
12:20:46     
12:20:46     </end perf map content>
12:20:46     
12:20:46         at runSuite (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:145:10)
12:20:46         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js:148:1)
12:20:46         at Module._compile (node:internal/modules/cjs/loader:1476:14)
12:20:46         at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
12:20:46         at Module.load (node:internal/modules/cjs/loader:1288:32)
12:20:46         at Module._load (node:internal/modules/cjs/loader:1104:12)
12:20:46         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
12:20:46         at node:internal/main/run_main_module:30:49 {
12:20:46       generatedMessage: false,
12:20:46       code: 'ERR_ASSERTION',
12:20:46       actual: 2,
12:20:46       expected: 0,
12:20:46       operator: 'strictEqual'
12:20:46     }
12:20:46     
12:20:46     Node.js v23.0.0-pre
12:20:46   ...
12:20:46 
12:20:46 Failed tests:
12:20:46 out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js
  ...

Failed tests:
out/Release/node /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf-logger.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v22.0.0 breaks --v8-lite-mode build missing action for js-to-wasm-tq-csa.cc
6 participants