Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove --no-experimental-global-customevent flag #52723

Merged
merged 2 commits into from Apr 29, 2024
Merged

cli: remove --no-experimental-global-customevent flag #52723

merged 2 commits into from Apr 29, 2024

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Apr 27, 2024

This removes the --no-experimental-global-customevent flag as a follow-up for #52618.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Apr 27, 2024
@daeyeon daeyeon added semver-major PRs that contain breaking changes and should be released in the next major version. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. and removed c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 27, 2024
@daeyeon
cli: remove --no-experimental-global-customevent flag
67cb034 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon
doc: mark CustomEvent in globals as stable
aee1577 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon daeyeon force-pushed the main.customevt-240427.Sat.c33b branch from 419cea9 to aee1577 Compare April 27, 2024 15:15
@panva panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 27, 2024
mcollina
mcollina approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58789/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58790/

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit f7e73cd into nodejs:main Apr 29, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f7e73cd

aduh95 pushed a commit that referenced this pull request Apr 30, 2024
@daeyeon @aduh95
cli: remove --no-experimental-global-customevent flag
38410c0 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #52723
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@daeyeon @Ch3nYuY
cli: remove --no-experimental-global-customevent flag
4dcac61 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: nodejs#52723
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@daeyeon @nodejs-github-bot @mcollina @panva @jasnell @benjamingr @anonrig @MoLow @VoltrexKeyva @atlowChemi