Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch: allow listening for grouped changes #52722

Merged
merged 1 commit into from May 12, 2024
Merged

watch: allow listening for grouped changes #52722

merged 1 commit into from May 12, 2024
+36 −9

Conversation

matthieusieben
Copy link
Contributor

Fixes #52721

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 27, 2024
@matthieusieben
Copy link
Contributor Author

Capture d’écran 2024-04-27 à 14 41 06

@jasnell
Copy link
Member

jasnell commented Apr 27, 2024

Is it possible to add a test for this change?

@matthieusieben
Copy link
Contributor Author

@jasnell done

@matthieusieben matthieusieben force-pushed the fix-52721 branch 3 times, most recently from 5d423c6 to 7df71f8 Compare April 29, 2024 08:17
@matthieusieben
Copy link
Contributor Author

@jasnell Is there anything else you need ?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58926/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59120/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit c75675c into nodejs:main May 12, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c75675c

targos pushed a commit that referenced this pull request May 12, 2024
@matthieusieben @targos
watch: allow listening for grouped changes
d71e161 
PR-URL: #52722
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch does not debounce restart when different files are updated within the debounce period
4 participants
@matthieusieben @jasnell @nodejs-github-bot @aduh95