Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make start of signal_wrap reenterable #52103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theanarkh
Copy link
Contributor

make start of signal_wrap reenterable.

const Signal = internalBinding('signal_wrap').Signal;
const { signals } = internalBinding('constants').os;

const signal = new Signal();
signal.start(signals.SIGUSR2);
signal.start(signals.SIGINT);
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Mar 15, 2024
Comment on lines 8 to 9
if (!common.isMainThread)
common.skip('Signal handling in Workers is not supported');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
if (!common.isMainThread)
common.skip('Signal handling in Workers is not supported');
common.skipIfWorker();

test/parallel/test-signal-reuse.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants