test: add fuzzer for native/js string conversion #51120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
anonrig
approved these changes
Dec 15, 2023
anonrig
added
the
author ready
github-actions
bot
removed
the
request-ci
joyeecheung
reviewed
Dec 15, 2023
joyeecheung
reviewed
Dec 15, 2023
| std::vector<std::string> exec_argv; | ||
| std::vector<std::string> errors; | ||
|
|
||
| node::InitializeNodeWithArgs(&node_argv, &exec_argv, &errors); |
There was a problem hiding this comment.
Can this just use node::InitializeOncePerProcess() instead? Then there's no need to repeat the initialization routines below (and potentially missing some steps whenever there are internal updates), unless there's a reason that those have to be customized (from what I can tell, that's not necessary?)
github-actions
bot
removed
the
request-ci
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: nodejs#51120 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
aduh95
force-pushed
the
add-string-fuzzers
branch
from
919306c
to
c8805b8
Compare
|
Landed in c8805b8 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51120 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fuzzer for the following APIs:
napi_create_string_utf8napi_get_value_string_utf8napi_create_string_latin1napi_get_value_string_latin1The PR also adds the fuzzer to Node's OSS-Fuzz build, so that OSS-Fuzz will run this fuzzer continuously.