Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chocolatey Guide for node-gyp on Windows #3008

Merged
merged 7 commits into from Apr 7, 2024

Conversation

Eprince-hub
Copy link
Contributor

@Eprince-hub Eprince-hub commented Apr 4, 2024

Closes #2636

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Update the documentation for Node-Gyp installation on Windows by adding a guide for using Chocolatey to simplify the installation of the required dependencies for the node-gyp. The proposed guide simplifies the process by providing a one-liner command to install the necessary dependencies, namely Python and Visual Studio 2022 workload for C++ tools

@Eprince-hub Eprince-hub marked this pull request as draft April 4, 2024 14:30
@Eprince-hub Eprince-hub marked this pull request as ready for review April 4, 2024 14:48
README.md Outdated Show resolved Hide resolved
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss added the Windows label Apr 4, 2024
@Eprince-hub
Copy link
Contributor Author

@cclauss
Do you know if this test failure is something I need to look into? It doesn't seem connected to the PR

@cclauss
Copy link
Contributor

cclauss commented Apr 5, 2024

Re-running Tests / macos - 3.12 - 20.x (pull_request)...

Note

Success 👍

@cclauss cclauss merged commit 77737e4 into nodejs:main Apr 7, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Chocolatey VS installation steps and project-local msvs_version for Windows (#on-windows)
4 participants