Support rebuild and build when configure with -- -f make on Windows
#2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2024
|
The lint failing here will be resolved by: |
|
@cclauss Branch updated. Once nodejs/gyp-next#222 and nodejs/gyp-next#240 land in gyp-next 0.17.0 and this PR get merged, excited to see the next release of node-gyp can support build wasm! |
|
gyp 0.17.0 released, anyone can review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
node-gyp rebuildandnode-gyp builddoesn't work on windows if using-f maketo perform cross-compiling, this PR add support for it.Related: