Fix build bug in target arch config #2866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatlopez
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
coverage for this would be nice, seems like a rather important typo
unrelated: I'd recommend to move the fixes to the pr description
cclauss
requested review from
StefanStojanovic and
rvagg
and removed request for
StefanStojanovic
|
Please rebase this pull request to get fix the git conflict. |
moccajoghurt
force-pushed
the
main
branch
2 times, most recently
from
b00695e
to
b030555
Compare
|
Please rebase this pull request so we can get all tests to pass. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2865
[x]
npm install && npm testpassesFixed build bug in target arch config by fixing a typo.