Update docs node-gyp update when using nvm #2791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
May 4, 2023
| @@ -41,6 +41,13 @@ $ npm explore npm/node_modules/npm-lifecycle -g -- npm install node-gyp@latest | |||
|
|
|||
| If the command fails with a permissions error, please try `sudo` and then the command. | |||
|
|
|||
| If you are using `nvm` and the logs indicate no change of the `node-gyp` version, you might need to specify the `node` version, for example do: | |||
| ```bash | |||
| $ cd /home/user/.nvm/versions/node/v18.13.0/node_modules/npm/node_modules/@npmcli/run-script | |||
There was a problem hiding this comment.
Thanks for doing this. Please clarify for the reader how you chose this path. Also, what about adding npm list before and after so the reader knows how to verify that the expected changes were made.
There was a problem hiding this comment.
While you are in here, can you please update line 32 to say 7 or greater you cover npm 9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
In case of using nvm, the regular update of node-gyp might not apply. Added a new section to the docs to clearify this. Before this you would execute the instructions but the node-gyp version did not change. Instead this new instruction helps to specify the node version and update node-gyp accordingly.