feat(gyp): update gyp to v0.9.6 #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
couple of windows issues there but rubber stamp from me if you can figure those out |
gengjiawen
commented
Aug 10, 2021
Closed
gengjiawen
changed the title
gengjiawen
commented
Aug 18, 2021
gyp/pylib/gyp/msvs_emulation.py
Outdated
| @@ -67,7 +74,8 @@ def EncodeRspFileList(args): | |||
| program = call + " " + os.path.normpath(program) | |||
| else: | |||
| program = os.path.normpath(args[0]) | |||
| return program + " " + " ".join(QuoteForRspFile(arg) for arg in args[1:]) | |||
| return (program + " " + | |||
There was a problem hiding this comment.
Looks different lint rules result in this. Should we skip gyp lib in this repo or unify the rule ? @cclauss
Run flake8 . --ignore=E203,W503 --max-complexity=101 --max-line-length=88 --show-source --statistics
./gyp/pylib/gyp/msvs_emulation.py:77:27: W504 line break after binary operator
return (program + " " +
^
1 W504 line break after binary operator
There was a problem hiding this comment.
Put the + at the beginning of the next line.
There was a problem hiding this comment.
Should we add this rule in https://github.com/nodejs/gyp-next ?
Also should we disable flake8 test for this repo since gyp sources is an upstream project ?
gengjiawen
changed the title
|
@rvagg This id ready for review. |
rvagg
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change