windows related fix #118
Merged
windows related fix #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really have no idea and am not the right person to 👍 this. I assume this fixes CI? I don't know what the implications for the cp1251 change are. @cclauss: are we risking some edge we're not accounting for properly? |
It recently add by 4d0f93c. |
owl-from-hogvarts
added a commit
to owl-from-hogvarts/gyp-next
that referenced
this pull request
Jul 31, 2022
proper fix for nodejs#118 Special thanks to @cclauss
owl-from-hogvarts
added a commit
to owl-from-hogvarts/gyp-next
that referenced
this pull request
Sep 7, 2022
proper fix for nodejs#118 Special thanks to @cclauss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly revert 4d0f93c for windows issue. See nodejs/node-gyp#2481.
And add related github action to prevent future regression.
@cclauss @rvagg