gyp: update gyp to v0.9.1 #2402
Conversation
| @@ -1,7 +1,7 @@ | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - main | |||
There was a problem hiding this comment.
I am not a fan of master --> main but it is all the rage these daze...
- We need to document how contributors change their local forks.
- We need to document how contributors change the 29 open PRs.
- https://github.com/nodejs/node-gyp/blob/master/.github/workflows/release-please.yml#L6 must change.
- We need to document how this change effects the repo chain of gyp-next --> node-gyp --> node.
There was a problem hiding this comment.
It's in https://github.com/nodejs/gyp-next. The change to main branch has been made in nodejs/gyp-next#103 by @targos . It's out of scope for this repo :)
There was a problem hiding this comment.
It's out of scope for this repo :)
👍
If that topic does come up here, or elsewhere in the Node ecosystem, most of the documentation around that from GitHub is collected here: https://github.com/github/renaming/
(Using the GitHub.com UI to rename a branch from master to main will cause GitHub to seamlessly handle most of it behind the scenes, according to the bullet points at the bottom of that repo's README.md.)
There was a problem hiding this comment.
Every contributor needs to do this for 1. How do they do 2.?
There was a problem hiding this comment.
- is done automatically by github when the branch is renamed.
There was a problem hiding this comment.
The destination branches of all 29 pull requests are changed automatically?!?
Like commit into nodejs:master at the top of this page:
gengjiawen wants to merge 1 commit into nodejs:master from gengjiawen:feat/gyp_bump
Cool! Thanks.
There was a problem hiding this comment.
I think it is easier to understand the instructions for 1. with long flags rather than short flags... (And I added links to the git subcommand documentation)
$ git branch --move OLD-BRANCH-NAME NEW-BRANCH-NAME
$ git fetch origin
$ git branch --set-upstream-to=origin/NEW-BRANCH-NAME NEW-BRANCH-NAME
$ git remote set-head origin --auto
|
|
||
| ### Bug Fixes | ||
|
|
||
| * py lint ([3b6a8ee](https://www.github.com/nodejs/gyp-next/commit/3b6a8ee7a66193a8a6867eba9e1d2b70bdf04402)) |
There was a problem hiding this comment.
https://www.pylint.org is not something that we use (because we use flake8 instead) so this comment might confuse some readers but we should push forward with this release.
Features
Bug Fixes