Skip to content

Commit

Permalink
fix: node.js debugger adds stderr (but exit code is 0) -> shouldn't t…
Browse files Browse the repository at this point in the history
…hrow
  • Loading branch information
FuPeiJiang committed Aug 19, 2022
1 parent 8958ecf commit 93df27b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion gyp/pylib/gyp/input.py
Expand Up @@ -979,8 +979,9 @@ def ExpandVariables(input, phase, variables, build_file):
p_stdout = p_stdout.decode("utf-8")
p_stderr = p_stderr.decode("utf-8")

if p.wait() != 0 or p_stderr:
if p_stderr:
sys.stderr.write(p_stderr)
if p.wait() != 0:
# Simulate check_call behavior, since check_call only exists
# in python 2.5 and later.
raise GypError(
Expand Down

0 comments on commit 93df27b

Please sign in to comment.