Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow non-empty stderr in runSync #410

Merged
merged 1 commit into from May 5, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 5, 2020

Refs #402 (comment).

Allow a non-empty stderr in runSync and instead error on a non-zero exit status; git sometimes outputs its messages to stderr so this has potential to cause unexpected failures.

cc @targos @joyeecheung

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   76.28%   76.28%           
=======================================
  Files          21       21           
  Lines        1480     1480           
=======================================
  Hits         1129     1129           
  Misses        351      351           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255e660...58a1f5d. Read the comment docs.

@joyeecheung joyeecheung merged commit 157b508 into nodejs:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants