fix: undefined failures & JSON error

nodejs · Oct 19, 2020 · 2c0cf83 · 2c0cf83
1 parent 5ad7e4e
commit 2c0cf83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/bin/ncu-ci b/bin/ncu-ci
@@ -353,11 +353,11 @@ class CICommand {
       await build.getResults();
       build.display();
 
-      if (argv.json) {
-        const json = build.formatAsJson();
-        if (json !== undefined) {
-          this.json = this.json.concat(json);
-        }
+      // Set this.json regardless of whether the user has passed
+      // --json - it's needed for failure aggregation.
+      const json = build.formatAsJson();
+      if (json !== undefined) {
+        this.json = this.json.concat(json);
       }
 
       if ((argv.copy || argv.markdown) && !argv.stats) {

diff --git a/lib/ci/failure_aggregator.js b/lib/ci/failure_aggregator.js
@@ -3,9 +3,9 @@
 const _ = require('lodash');
 const chalk = require('chalk');
 const { getMachineUrl, parsePRFromURL } = require('../links');
+const { FAILURE_TYPES_NAME } = require('./ci_failure_parser');
 const {
   parseJobFromURL,
-  FAILURE_TYPES_NAME,
   CI_TYPES
 } = require('./ci_type_parser');
 const {