Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move dependency to editor-client #4702

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 14, 2024

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Moves dependencies to the correct package.json.
Should not change the behavour.

Draft because maybe some packages are missing.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Rotzbua Rotzbua marked this pull request as draft May 14, 2024 20:20
@hardillb
Copy link
Member

The build/dev process depends on these being in the root package.json

Nothing will install them if they are moved to the sub packages.

@knolleary
Copy link
Member

We do not need to make these changes. The package dependency lists are correct as they are given how we build and publish the modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants