Allow blank strings to be used for env var property substitutions #4672
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4663
If an env var is a blank string (``FOO=""
), and is used in a property substitution (${FOO}`), then we were not replacing it with a blank string, but leaving the `${FOO}` value in place.This was a slightly intentional behaviour when we first introduced true env var support, but as they have expanded to be more widely used with subflow properties etc, then it makes sense to allow inserting a blank string if the env var is explicitly set to a blank string (rather than undefined).
Given this might be a change in behaviour for some obscure edge cases, I'm putting this in 4.0, rather than 3.x.