Add npm install timeout notification #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the test is failing, while it is in the node install space, it appears to be testing the backend, not the frontend, so should not be impacted by the changes. |
|
OK, test passed when I rebased the branch on the dev branch |
knolleary
requested changes
Apr 18, 2024
packages/node_modules/@node-red/editor-client/locales/en-US/editor.json
Outdated
Show resolved
Hide resolved
…itor.json Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
knolleary
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4622
Proposed changes
Adds a notification if the HTTP POST to install a new node is closed by a intermediate proxy (e.g. nginx)
Checklist
npm run testto verify the unit tests pass