Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Property in out on core nodes #4656

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Support Property in out on core nodes #4656

wants to merge 17 commits into from

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Apr 12, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

In alignment with proposals in #4651:

  • Adds "Property Out" field where sensible
  • Updates "Property In" field to clarify input/output

Nodes Updated:

In the format proposed by #4651, the name field was moved to the top, the input property is next and the new (or existing) output property was placed at the end (or at the end of main properties / above the <hr> and advanced properties in some nodes)

TODO:

  • Post before and after screenshots in the issue for evaluation and agreement
  • Write tests for affected nodes.
    • Where applicable, tests should set property and verify the input data should be taken from the correct msg property
    • Where applicable, tests should set propertyOut and verify the results go to the correct msg property
  • Update built in help for affected nodes
  • Switch PR out of draft

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested a review from dceejay April 25, 2024 17:15
@Steve-Mcl Steve-Mcl marked this pull request as ready for review April 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: core nodes to permit input and output to properties other than the hard coded payload
1 participant